rusackas commented on code in PR #43635:
URL: https://github.com/apache/superset/pull/43635#discussion_r3878268908


##########
docs/admin_docs/installation/kubernetes.mdx:
##########
@@ -319,6 +320,42 @@ configOverrides:
     AUTH_USER_REGISTRATION_ROLE = "Admin"
 ```
 
+### Exposing Superset via Gateway API (HTTPRoute)
+
+As an alternative to `Ingress`, the chart can create a [Gateway 
API](https://gateway-api.sigs.k8s.io/)
+`HTTPRoute` that attaches to a Gateway already running in your cluster. This 
requires the Gateway
+API CRDs (`gateway.networking.k8s.io/v1`) to be installed, along with a 
Gateway resource for the
+route to attach to.
+
+```yaml
+httproute:
+  enabled: true
+  parentRefs:
+    - name: my-gateway
+      namespace: gateway-system

Review Comment:
   Good catch — added a note about `allowedRoutes` for cross-namespace 
attachment.



##########
docs/admin_docs/installation/kubernetes.mdx:
##########
@@ -319,6 +320,42 @@ configOverrides:
     AUTH_USER_REGISTRATION_ROLE = "Admin"
 ```
 
+### Exposing Superset via Gateway API (HTTPRoute)
+
+As an alternative to `Ingress`, the chart can create a [Gateway 
API](https://gateway-api.sigs.k8s.io/)
+`HTTPRoute` that attaches to a Gateway already running in your cluster. This 
requires the Gateway
+API CRDs (`gateway.networking.k8s.io/v1`) to be installed, along with a 
Gateway resource for the
+route to attach to.
+
+```yaml
+httproute:
+  enabled: true
+  parentRefs:
+    - name: my-gateway
+      namespace: gateway-system
+  hostnames:
+    - superset.example.com
+  rules:
+    - matches:
+        - path:
+            type: PathPrefix
+            value: /
+```
+
+- `httproute.parentRefs` lists the Gateway(s) the route attaches to.
+- `httproute.hostnames` matches against the HTTP `Host` header; it's 
templated, so values like
+  `{{ .Release.Name }}` can be used.
+- `httproute.rules` are routing rules backed by the Superset service; each 
rule accepts standard
+  `matches`, `filters`, and `timeouts` fields, and an optional `weight` 
(defaults to `1`) to leave
+  room for traffic splitting across multiple rules.
+- If `supersetWebsockets.enabled` is set, an extra rule routing 
`supersetWebsockets.ingress.path`

Review Comment:
   Fair point, the wording was misleading since each rule only has one backend 
here. Reworded to make clear `weight` has no splitting effect with this 
template.



##########
docs/admin_docs/installation/kubernetes.mdx:
##########
@@ -319,6 +320,42 @@ configOverrides:
     AUTH_USER_REGISTRATION_ROLE = "Admin"
 ```
 
+### Exposing Superset via Gateway API (HTTPRoute)
+
+As an alternative to `Ingress`, the chart can create a [Gateway 
API](https://gateway-api.sigs.k8s.io/)
+`HTTPRoute` that attaches to a Gateway already running in your cluster. This 
requires the Gateway
+API CRDs (`gateway.networking.k8s.io/v1`) to be installed, along with a 
Gateway resource for the
+route to attach to.
+
+```yaml
+httproute:
+  enabled: true
+  parentRefs:
+    - name: my-gateway
+      namespace: gateway-system
+  hostnames:
+    - superset.example.com
+  rules:
+    - matches:
+        - path:
+            type: PathPrefix
+            value: /
+```
+
+- `httproute.parentRefs` lists the Gateway(s) the route attaches to.
+- `httproute.hostnames` matches against the HTTP `Host` header; it's 
templated, so values like
+  `{{ .Release.Name }}` can be used.
+- `httproute.rules` are routing rules backed by the Superset service; each 
rule accepts standard
+  `matches`, `filters`, and `timeouts` fields, and an optional `weight` 
(defaults to `1`) to leave
+  room for traffic splitting across multiple rules.
+- If `supersetWebsockets.enabled` is set, an extra rule routing 
`supersetWebsockets.ingress.path`
+  (default `/ws`) to the `-ws` service is appended automatically, mirroring 
the `Ingress` behavior
+  so global async queries keep working behind a Gateway.
+- If `supersetMcp.enabled` and `supersetMcp.httproute.enabled` are both set, 
an extra rule routing
+  `supersetMcp.httproute.path` to the `-mcp` service is appended as well.

Review Comment:
   Added a warning to enable MCP auth before exposing that route, linking to 
the MCP auth doc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to