Abdulrehman-PIAIC80387 commented on PR #41994: URL: https://github.com/apache/superset/pull/41994#issuecomment-5449038581
Closing this for now. Reviewer feedback has made it clear that a change touching ON DELETE semantics across ~60 FK constraints needs a SIP to align on SET NULL vs CASCADE policy before any code lands. That's a governance step that belongs on the mailing list, not inside a PR, and it will take longer than a review cycle. There are also two design points I need to rework before revisiting: - The DB-level cascade on `FavStar` bypasses `FavStarUpdater.after_delete`, so with `TAGGING_SYSTEM` enabled the derived `favorited_by:<user>` `TaggedObject` rows leak. Cleanup needs to happen at the ORM layer, not just the schema. - The `user_attributes.user` relationship isn't `passive_deletes`, so the normal `session.delete(user)` path nulls `user_id` in the ORM before the DB CASCADE runs, leaving the row orphaned. The relationship needs to defer to DB semantics. The test approach also needs to shift from ORM-metadata assertions to a real migration + delete round-trip so a silently-skipped constraint change would actually fail the suite. Closing rather than leaving in draft to avoid noise in review queues. Branch stays on the fork; happy to revive this (or open a fresh PR) once a SIP has landed and the design questions are settled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
