rusackas commented on code in PR #43639:
URL: https://github.com/apache/superset/pull/43639#discussion_r3878263222
##########
docs/admin_docs/configuration/theming.mdx:
##########
@@ -138,6 +138,18 @@ The existing `APP_NAME` Python config key continues to
work for backward compati
Email and alert/report notification subjects are driven by backend settings
such as
`EMAIL_REPORTS_SUBJECT_PREFIX` and `APP_NAME`, not by this theme token.
+To hide the logo image in the navbar entirely (for example, when a text-only
+brand is preferred), set `HIDE_NAVBAR_LOGO` in `superset_config.py`:
+
+```python
+# Hide the logo image in the navbar. The brand text (brandAppName / APP_NAME)
+# still renders if configured. Defaults to False.
Review Comment:
You're right — HIDE_NAVBAR_LOGO hides the whole brand area, not just the
logo image. Reworded the doc to say so.
##########
docs/admin_docs/configuration/theming.mdx:
##########
@@ -454,6 +466,115 @@ THEME_DEFAULT = {
This feature provides powerful theming capabilities while maintaining the
flexibility of ECharts' extensive configuration options.
+## Component Sizing & Style Tokens
+
+:::note
+Available since Superset 6.1
+:::
+
+Beyond colors and fonts, a handful of Superset-specific tokens let you tune the
+sizing, radius, and outline behavior of individual UI components. All of these
+tokens are optional — omit them and components fall back to their existing
+defaults, so applying them is a zero-visual-change operation until you opt in.
+
+### Button & DropdownButton Sizing
+
+```python
+THEME_DEFAULT = {
+ "token": {
+ # ... other tokens
+ "buttonControlHeight": 32, # default button height, in px
+ "buttonControlHeightSM": 30, # small/dropdown button height, in px
+ "buttonControlHeightXS": 24, # xsmall button height, in px
+ "buttonPaddingInline": 16, # horizontal padding, in px
+ "buttonPaddingInlineSM": 12, # horizontal padding for small buttons,
in px
+ "buttonFontSize": 14,
+ "buttonBorderRadius": 4,
+ }
+}
+```
+
+`buttonControlHeight` and `buttonBorderRadius` also drive the sizing of the
+menu-trigger button used by `PageHeaderWithActions`, so a single pair of tokens
+keeps page-header icon buttons visually consistent with regular buttons.
+
+For one-off overrides that shouldn't apply to every button in the app, pass a
+`styleConfig` prop directly to `Button` or `DropdownButton` instead of setting
+a theme token:
+
+```tsx
+<Button
+ styleConfig={{
+ controlHeight: 40,
+ paddingInline: 20,
+ fontSize: 16,
+ fontWeight: 700,
+ borderRadius: 8,
+ ctaMinWidth: 120,
+ ctaMinHeight: 40,
+ iconGap: 8,
+ }}
+>
+ Click me
+</Button>
+
+<DropdownButton
+ styleConfig={{
+ controlHeight: 32,
+ fontSize: 14,
+ fontWeight: 500,
+ boxShadow: '0 2px 4px rgba(0,0,0,0.1)',
+ }}
+ menu={menuProps}
+>
+ Options
+</DropdownButton>
+```
+
+`styleConfig` values take precedence over the equivalent theme tokens, which in
+turn take precedence over the built-in defaults.
+
+### Label Border Radius
+
+```python
+THEME_DEFAULT = {
+ "token": {
+ "labelBorderRadius": 4, # defaults to 8px
+ }
+}
+```
+
+### Select Option Outline
+
+By default, hovering or navigating to an option in a `Select` dropdown draws a
+2px outline in `colorPrimary`. Set `selectOptionActiveOutline` to `False` for a
+more subtle hover style with no outline:
+
+```python
+THEME_DEFAULT = {
+ "token": {
+ "selectOptionActiveOutline": False,
+ }
+}
+```
+
+### Dashboard Tile Appearance
+
+Chart tiles on a dashboard (not text/markdown tiles) can be restyled via
+`dashboardTile*` tokens. All fall back to the existing look — a
+`colorBgContainer` background with no border and a hairline `box-shadow`:
Review Comment:
Good catch — chart tiles do default to a 1px colorBorder border, and the
box-shadow only kicks in during the fade-out transition. Fixed the fallback
description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
