SEPURI-SAI-KRISHNA commented on PR #43222: URL: https://github.com/apache/superset/pull/43222#issuecomment-5450593789
Gentle nudge on this one — it's been open since Aug 15 without a first review. +134/-3 across two files, 115 of which are tests. A `Decimal` metric renders as **0%** in every row of a contribution chart that uses cross-query totals — no error, just silently wrong numbers. `ensure_totals_available()` filters totals with `df[col].dtype.kind in "biufc"`, which doesn't cover `object` — and that's where `decimal.Decimal` values live, since drivers like psycopg2 return `NUMERIC`/`DECIMAL` that way. With no totals entry, `contribution()` takes its `total is None` branch and assigns zero. The values are perfectly summable: `Series.sum()` on a Decimal column returns a `Decimal`, and `Decimal / Decimal` is exact. Only the dtype test excludes them. Strings, dicts, datetimes and all-null object columns stay excluded exactly as before. CI is green (62 passing). Happy to adjust the helper's shape if you'd rather it live elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
