sadpandajoe commented on code in PR #43627:
URL: https://github.com/apache/superset/pull/43627#discussion_r3879575782
##########
superset/migrations/versions/2026-08-21_12-00_7e2c9a4f1b83_create_task_dependencies_table.py:
##########
@@ -148,9 +148,22 @@ def upgrade():
"uq_task_subscribers_task_guest", ["task_id", "guest_key"]
)
+ # Liveness marker for orphan detection: the executing worker bumps
+ # ``tasks.last_heartbeat`` on a background thread, and the prune cron reaps
+ # ACTIVE tasks whose heartbeat has gone stale (a dead/orphaned worker). The
+ # index backs the reaper's ``last_heartbeat < now - timeout`` scan.
+ add_columns(
Review Comment:
Upgrades that already ran this revision will never execute these added DDL
statements, so their `tasks` table lacks `last_heartbeat` and the new
heartbeat/reaper paths fail at runtime. Could this column and index be added in
a new migration revision instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
