msyavuz commented on code in PR #43405:
URL: https://github.com/apache/superset/pull/43405#discussion_r3879776926
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx:
##########
@@ -430,26 +429,6 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
clearAllTrigger,
]);
- useEffect(() => {
- const prev = prevDataRef.current;
- const curr = data;
-
- const hasDataChanged =
- prev?.length !== curr?.length ||
- prev?.some((row, i) => {
- const prevVal = row[col];
- const currVal = curr[i][col];
- return typeof prevVal === 'bigint' || typeof currVal === 'bigint'
- ? prevVal?.toString() !== currVal?.toString()
- : prevVal !== currVal;
- });
-
- // If data actually changed (e.g., due to parent filter), reset flag
- if (hasDataChanged) {
- prevDataRef.current = data;
- }
- }, [data, col]);
-
useEffect(() => {
Review Comment:
Yes, it's now in the pr rather than a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
