bito-code-review[bot] commented on PR #43649: URL: https://github.com/apache/superset/pull/43649#issuecomment-5454586606
<!-- Bito Reply --> The flagged issue is correct. The PR introduces a `semantic_view` relationship and updates display helpers (`datasource_link`, `datasource_url`, `datasource_name_text`, `datasource_edit_url`) to resolve through `_display_datasource()`, which correctly handles semantic views. However, the chart response schema (likely in `superset/charts/schemas.py` or similar) still relies on the hard-coded `table.uuid` or `datasource_uuid` field, which is not updated to resolve the semantic view's UUID. To resolve this, you should update the chart response schema to resolve the `datasource_uuid` dynamically based on the `datasource_type`, similar to how the display helpers now use `_display_datasource()`. You can add a property or method to the `Slice` model that returns the correct UUID based on the datasource type, and update the schema to use this property. I have checked the PR comments and there are no other comments to address. Would you like me to implement the schema update for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
