mikebridge commented on PR #43629:
URL: https://github.com/apache/superset/pull/43629#issuecomment-5456059238
Follow-up pushed as db0e80894a addressing the two bot notes on `AsyncSelect`:
- **Stale error after a cached page** (CodeAnt): `setError('')` now runs at
the top of `fetchPage`, before the `allValuesLoaded` and `fetchedQueries` early
returns.
- **Late failure from a superseded fetch** (Bito): the `.catch` now applies
the same rule the `.then` branch already uses for results — a rejection whose
`search` no longer matches the current input is dropped rather than overwriting
the newer fetch's outcome. This reuses the existing `inputValueRef` check
instead of adding a generation counter.
Both have tests that fail against the previous code. For the record, Bito's
follow-up reply stating the clear was already before the early returns was
describing the intended fix, not the code as pushed — hence this commit.
The `sharded-jest-tests (3)` failure was
`SqlLab/components/SqlEditor/SqlEditor.test.tsx` hitting a jsdom/nwsapi
`SyntaxError` on an antd Tabs selector with a random id; that file is untouched
here and passes locally (15/15). The new push re-runs the shard.
_Comment generated by Claude (AI) on behalf of @mikebridge._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
