aminghadersohi commented on code in PR #43632:
URL: https://github.com/apache/superset/pull/43632#discussion_r3883138388
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx:
##########
@@ -967,7 +967,7 @@ const FiltersConfigForm = (
return (
<Tabs
allowOverflow={false}
- contentHeight={`calc(100vh - ${theme.sizeUnit * 55}px)`}
+ fullHeight
Review Comment:
Third leg of the height chain covered by the blocker in the review body.
`fullHeight` sets `height: 100%` on `.ant-tabs`, `.ant-tabs-body`,
`.ant-tabs-content` and `.ant-tabs-body-holder` (`Tabs.tsx:49-64`), replacing
the `calc(100vh - 220px)` that was the only thing giving
`.ant-tabs-body-holder` a resolvable height here. Measured with
`allowOverflow={false}` in the non-expanded modal, the holder goes from
`clientHeight` 493 / `scrollHeight` 2000 (scrolls) to 2001 / 2001 (does not),
so its `overflow: auto` never engages.
Worth noting `contentHeight` already defaults to `'100%'` and is emitted
after the `fullHeight` line, so `fullHeight` is not what changes the holder's
height here — dropping the explicit `contentHeight` is. Direction is right (the
`sizeUnit * 55` magic number should go); it just needs an ancestor with a
definite height first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
