mikebridge opened a new pull request, #43657: URL: https://github.com/apache/superset/pull/43657
### SUMMARY Fixes the `sharded-jest-tests (3)` flake in `SqlEditor.test.tsx` (`SyntaxError: 'button,,,,,,<id>-more.ant-tabs-nav-more .ant-tabs-tab-btn:focus-visible' is not a valid selector`) that has been costing unrelated PRs a re-run since ~08-27 (#42760, #43633, #43619, others). Root cause is upstream: nwsapi 2.2.23's `:has()` resolver rewrites `:scope` into a malformed reference selector (dperini/nwsapi#157, closed 2026-07-10). jsdom reaches it while matching antd's Tabs rule `.ant-tabs-tab-focus:has(.ant-tabs-tab-btn:focus-visible)` during React Testing Library's accessible-name computation for the Tabs overflow "more" button — which `findByRole` polling in `SqlEditor.test.tsx` (added by #43330) now exercises. Full analysis and stack in #43656. Dependency path: `[email protected] → [email protected] → [email protected]`, pinned by the lockfile within the existing `overrides` entry `"nwsapi": "^2.2.13"`. This raises the floor to `^2.2.24` and updates the lock entry. No code or test changes. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable. ### TESTING INSTRUCTIONS ``` cd superset-frontend && npm ci && npx jest src/SqlLab/components/SqlEditor/SqlEditor.test.tsx ``` Run it several times. On master (nwsapi 2.2.23) roughly one run in three fails with the selector `SyntaxError`; with this change six consecutive runs passed locally (2.2.25 was also verified 6/6). A single `-t` test does not reproduce the flake — the whole file has to run. ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #43656 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API *Analysis and fix produced with AI assistance (Claude); verified locally as described.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
