mikebridge commented on PR #42760:
URL: https://github.com/apache/superset/pull/42760#issuecomment-5457700099
One more commit, `34fa8f6f57`, closing three items from a fresh multi-lens
pass over the post-approval delta:
- **Freshness bound.** Lookup (and the store dedupe) now honor the
*requesting* chart's resolved timeout. Per-request timeouts (`f0e9e32685`) had
let a value stored by a 3600 s chart answer a 60 s chart on the same view for
the value's whole life — the old last-writer bucket TTL was bounding that by
accident and `7eb97a33a3` removed the accident. A short-lived registration also
no longer pins a longer-lived chart to its entry.
- **Secret-like identity material → bypass, not failure.**
`SensitiveIdentityMaterialError` was raised from `build_cache_configuration`,
ahead of the cache service's exception boundary, so a provider returning e.g.
`{"tenant_token_version": 1}` would have failed every chart on that view once
the flag is on. It now costs a containment bypass with a warning naming the
view (not the material); covered at the host and mapper level.
- **CI scoping.** `scripts/change_detector.py`'s `semantic-layers` pattern
now includes `superset/async_events/cache_backend.py` and
`superset/utils/cache_manager.py` — the owner-token lease code the real
Redis/Sentinel job exists to test — so a Lua-script edit can't skip it
(@rusackas, follow-on to your CI-scope nit).
No behaviour change for correctly configured deployments beyond the
freshness bound. Semantic-layers coverage still 100%.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
