bito-code-review[bot] commented on code in PR #43653:
URL: https://github.com/apache/superset/pull/43653#discussion_r3884025047
##########
superset-frontend/jest.config.js:
##########
@@ -18,6 +18,19 @@
*/
// timezone for unit tests
process.env.TZ = 'America/New_York';
+
+const reporters = ['default'];
+
+// HTML reporter is not used on CI so skipping its generation for saving time
+if (process.env.CI) {
+ reporters.push([
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Inverted CI condition</b></div>
<div id="fix">
The condition is inverted. The comment says the HTML reporter is skipped on
CI, and the original code added it only when `!process.env.CI`. As written, `if
(process.env.CI)` pushes the reporter on CI and omits it locally, reversing the
intent. Use `if (!process.env.CI)`.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
// HTML reporter is not used on CI so skipping its generation for saving time
if (!process.env.CI) {
reporters.push([
````
</div>
</details>
</div>
<small><i>Code Review Run #73a9a3</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
