rusackas opened a new pull request, #43662: URL: https://github.com/apache/superset/pull/43662
### SUMMARY Stacks on #43652. Pure infrastructure, no dialect changes: adds an opt-out mechanism so a future testcontainers dialect whose image is too heavy for per-PR CI (a multi-service cluster, a many-GB image, a slow licensed installer) can set `nightly_only: true` on its matrix entry and only run on the nightly cron or a manual `workflow_dispatch`, never on `pull_request`. No existing dialect uses the flag yet -- this just lays the groundwork for candidates like SAP HANA, Teradata, or Apache Druid, which came up while surveying testcontainers coverage but are too heavy to add to every PR's CI budget. The condition (`matrix.nightly_only != true || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'`) lives at the job level, evaluated per expanded matrix entry -- GitHub Actions resolves the matrix before evaluating a job's `if:`, so each matrix combination checks its own value. Omitting the field (the default for every dialect today) evaluates to `null != true`, which is `true`, so nothing changes for existing dialects. ### TESTING INSTRUCTIONS No dialect is currently flagged `nightly_only`, so this PR's own CI run should show all 16 existing dialects running exactly as before on `pull_request` -- confirms the new `if:` doesn't change current behavior. The skip path itself will be exercised the first time a future PR actually sets the flag on a real dialect. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
