bito-code-review[bot] commented on PR #43678: URL: https://github.com/apache/superset/pull/43678#issuecomment-5460230983
<!-- Bito Reply --> The flagged issue is correct. The current test setup does not properly simulate a blocked listener, meaning the test could pass even if the wake mechanism is broken. To resolve this, you should modify the test to ensure the listener is actually blocked in `xread` before triggering the wake, and then verify that the listener terminates promptly. I have checked the PR comments and there are no other comments to address. Would you like me to implement the fix for this test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
