aminghadersohi opened a new pull request, #43679:
URL: https://github.com/apache/superset/pull/43679
### SUMMARY
Make `update_chart`'s immediate-save path merge simplified configuration
changes onto the chart's existing `form_data`, matching the preview path. This
preserves visualization settings that are outside the MCP configuration schema
while still honoring explicit empty filter lists.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; this is an MCP persistence fix with no direct UI change.
### TESTING INSTRUCTIONS
1. Create a mixed time-series chart whose saved params include time
comparison and formatting settings.
2. Call `update_chart` with `generate_preview=false`, changing its metrics
through `config`.
3. Confirm the updated chart params contain the new metrics and retain the
unrelated time comparison and formatting settings.
4. Run:
```bash
pytest -q
tests/unit_tests/mcp_service/chart/tool/test_update_chart.py::TestBuildUpdatePayload::test_config_update_preserves_unrelated_mixed_timeseries_settings
```
Automated validation performed:
- `pre-commit run`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
