wuhyn commented on PR #43236:
URL: https://github.com/apache/superset/pull/43236#issuecomment-5461485813

   Hi @rusackas, thanks for providing an in-depth review.
   
   The shifting of the WEEK time grain caused by the change was actually 
unintentional, I can list this as behavioural cleanup in the original linked 
issue. I confirmed it actually sets the first day of the week as Monday 
according to ISO 8601 standards, similar to Postgres.
   
   ```
   db2 => select DATE_TRUNC('week', current_date) from sysibm.sysdummy1
   
   1                  
   -------------------
   2026-08-24-00.00.00
   
     1 record(s) selected.
   ```
   
   The DATE_TRUNC function was introduced in IBM Db2 for Linux, UNIX and 
Windows 11.1.0 version according to the [SQL compatibility enhancements 
docs](https://www.ibm.com/docs/en/db2/11.1.0?topic=ga-sql-compatibility-enhancements).
 I can list 11.1.0 as the minimum version requirement in the [Db2 supported 
database](https://superset.apache.org/user-docs/databases/supported/ibm-db2) 
section.
   
   It would be good to confirm with the containers. Please let me know if I 
need to do anything else to proceed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to