sadpandajoe commented on code in PR #43681:
URL: https://github.com/apache/superset/pull/43681#discussion_r3886665927
##########
.github/workflows/dependabot-auto-approve.yml:
##########
@@ -44,20 +44,12 @@ jobs:
permissions:
pull-requests: write # to post the approving review via `gh pr review`
steps:
- - name: Fetch Dependabot metadata
- id: metadata
- # This exact SHA is on ASF Infra's action allowlist
- # (apache/infrastructure-actions approved_patterns.yml) as of this
- # writing. Do not bump without opening an Infra ticket to allow
- # the new SHA first!
- uses:
dependabot/fetch-metadata@25dd0e34f4fe68f24cc83900b1fe3fe149efef98 # v3.1.0
-
+ # Dependabot automatically attaches semver labels (major, minor and
patch) to its generated PRs
- name: Approve patch-level bump
- if: steps.metadata.outputs.update-type == 'version-update:semver-patch'
+ if: contains(github.event.pull_request.labels.*.name, 'patch')
Review Comment:
The `patch` label is added after Dependabot opens the PR, but this workflow
only runs on `opened` and `synchronize`. That can leave a new patch update
unapproved with no later run to evaluate this guard. Could this also trigger on
`labeled` (or otherwise run after label assignment)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
