SBIN2010 commented on code in PR #43271:
URL: https://github.com/apache/superset/pull/43271#discussion_r3886796424
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -335,6 +341,19 @@ const SliceHeader = forwardRef<HTMLDivElement,
SliceHeaderProps>(
<CrossFilterIcon iconSize="m" />
</Tooltip>
)}
+ {slice.description && !isExpanded && (
+ <Popover
+ trigger={['hover', 'click']}
+ content={<SliceInfo slice={slice} />}
+ placement="leftBottom"
+ >
+ <Icons.InfoCircleOutlined
+ iconSize="m"
+ aria-label={t('Chart description')}
+ data-test="chart-description-info-icon"
+ />
+ </Popover>
+ )}
Review Comment:
@rusackas
Thanks for the recommendations; I’ve applied them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
