no-hup commented on PR #43549:
URL: https://github.com/apache/superset/pull/43549#issuecomment-5463201723
Thanks for re-running it and merging — sorry I didn't get back to you before
you did. For the record: that `sharded-jest-tests (3)` failure was
`SqlLab/SqlEditor.test.tsx` ("disables the save dataset button when the results
are not loaded"), plus a worker-teardown warning in the same shard. Nothing in
this diff touches SqlLab — it's confined to `createMemoryFormatter` — so it
looked like shard flakiness rather than fallout from the change. Happy to dig
into that test separately if it keeps showing up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]