gkneighb commented on PR #43567: URL: https://github.com/apache/superset/pull/43567#issuecomment-5463607277
@aminghadersohi — fixed the still-open `sort_by_metric` → `orderby` item in `eceedafe33`. Per your caveat, I did **not** stash `orderby` in `form_data` (confirmed that's a no-op on the MCP builder); instead `_build_single_query_dict` now emits `orderby = [(metrics[0], False)]` when `sort_by_metric` is set — which retroactively covers the identical latent no-op in pie/treemap/sankey too. Added a query-context test asserting the built query dict carries a descending metric `orderby`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
