gkneighb commented on PR #43570: URL: https://github.com/apache/superset/pull/43570#issuecomment-5463607387
@aminghadersohi — fixed #1 (the `x_axis` drop) in `d2c667c8b4`: `build_query_dicts_from_form_data` now folds `x_axis` into the GROUP BY columns for `heatmap_v2` too (it was time-series-only), so both axes reach the query. Added a query-context test asserting `day_of_week` and `hour` both appear in the built columns. On #2 (`normalize_across` → `rankOperator` post-processing): that's a real gap but a heavier fix (replicating the post-processing operator), and lower severity since the cells still render, just un-normalized — I've noted it as a follow-up rather than bundling it here. Agreed on the family synthesis — the durable fix is routing the MCP path through the real `buildQuery` / a shared server-side equivalent rather than re-deriving per chart. Happy to open a tracking issue for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
