bito-code-review[bot] commented on PR #43692:
URL: https://github.com/apache/superset/pull/43692#issuecomment-5469631999
<!-- Bito Reply -->
The flagged issue is correct. The `lastColumnRef` is initialized but never
updated when the user changes the column selection, causing it to hold stale
data when unchecking the whole-row mode. To resolve this, update
`lastColumnRef.current` whenever the column selection changes.
Would you like me to implement this fix? I can also check the other comments
on this PR if you would like to address them as well.
**superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx**
```
const handleColumnChange = (value: string) => {
lastColumnRef.current = value;
const newColumnType = columns.find(item => item.value ===
value)?.dataType;
const currentColumnType = columns.find(
item => item.value === column,
)?.dataType;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
