sadpandajoe commented on code in PR #43696: URL: https://github.com/apache/superset/pull/43696#discussion_r3890800959
########## superset/config.py: ########## @@ -2975,28 +2975,34 @@ def EMAIL_HEADER_MUTATOR( # pylint: disable=invalid-name,unused-argument # noq # Realtime websocket transport (the `superset-websocket` server) config. # When enabled, GTF task changes are pushed to the browser so charts and list -# views update without waiting for the interval poll (which stays as the -# fallback). Requires the superset-websocket server, a Redis coordination +# views update without polling: with the websocket on, the recurring +# `/task/status_changes` poll is not run at all — the socket is the mechanism, and Review Comment: This changes the documented completion contract, but `UPDATING.md:78-85` still says the interval poll is the correctness backstop and `UPDATING.md:106-112` instructs operators to grant Redis access to the old `entity-changes:*` and `task-status` channels. Deployments following that guide will configure the new single-channel transport incorrectly. Could the migration guidance be updated with this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
