7487 commented on PR #39658: URL: https://github.com/apache/superset/pull/39658#issuecomment-5473792829
Pushed two commits: - **7775ae1** reverts the `DataTable.tsx` pagination clamp that had slipped into this branch — it duplicates #39661 and was also what tripped the `oxfmt` pre-commit hook. This PR is now scoped to the formatter fix only (`formatValue.ts` + tests). - **cd6c5d6** adds a `logging.warn` in the catch (per review feedback, so formatter errors aren't silently swallowed) and unit tests covering the `String(value)` fallback for both the plain formatter and `CurrencyFormatter` paths — this also addresses the codecov patch-coverage gap. For the record on the other CI failures on the previous run: the jest shard 5 failure was a `FiltersConfigModal` keyboard-reorder timeout and `validate-frontend` was an `npm ls` dependency-tree error — neither touches files in this diff, so they should clear on re-run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
