plaes commented on PR #43692: URL: https://github.com/apache/superset/pull/43692#issuecomment-5476107959
> Additional Suggestions - 2 > * Saved color scheme ignored · [Line 262-266](https://github.com/apache/superset/pull/43692/files#diff-e56eace7454a23d3e1b37e7c8a2f37b6717a7ee710af40ac07c1cfde2900447fR262) > `colorSchemeValue` (line 263) falls back to `config?.colorScheme` only when `Form.useWatch('colorScheme', form)` is undefined, but the colorScheme Form.Item sets `initialValue={defaultColorToken}` ('colorSuccess'), so `useWatch` returns that on first render. A saved `config.colorScheme === Green/Red` is therefore ignored and `showOperatorFields` (264-266) stays true, contradicting the comment at 247-248. Consider initializing the form from `config` or removing the initialValue. I don't really understand this one... :( > * CELL_BAR non-numeric restore · [Line 336-345](https://github.com/apache/superset/pull/43692/files#diff-e56eace7454a23d3e1b37e7c8a2f37b6717a7ee710af40ac07c1cfde2900447fL350) > When whole-row is active and the user switches 'Formatting object' to CELL_BAR (that select is not disabled), the `!applyToWholeRow` guard skips correcting `columnFormatting` to a numeric column. On unchecking, `handleWholeRowChange` restores `previousColumnRef.current`, which may be non-numeric and absent from the CELL_BAR options in `getColumnOptions`, leaving an invalid select value and cell bars on a non-numeric column. Consider re-validating against `numericColumns` on restore. This is addressed in latest commit. This "simple" popover has really too many features ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
