sadpandajoe opened a new pull request, #43730:
URL: https://github.com/apache/superset/pull/43730
### SUMMARY
On the chart creation page (`/chart/add`), the vertical `Steps` component's
step titles, the dataset select, and the chart-type gallery all sit ~16px
further right than before the Ant Design v5 → v6 upgrade (#41636), and the
gallery is ~16px narrower.
Ant Design v6 restructured vertical `Steps` and moved the icon-to-content
gap off the icon and onto a new flex wrapper element (`.ant-steps-item-wrapper
{ column-gap: 16px }`). Superset's existing `.ant-steps-item-icon {
margin-right: 8px }` override used to fully replace antd's gap under v5's DOM
structure; under v6 it's purely additive on top of the wrapper's `column-gap`,
doubling the total gap from 8px to 24px.
### BEFORE/AFTER
Before: chart creation steps rendered at the original antd v5 spacing.
After: fields align back to the original spacing; no double gap.
### TESTING INSTRUCTIONS
1. Navigate to `/chart/add` ("Create a new chart").
2. Confirm the "Choose a dataset" and "Choose a chart type" step content,
the dataset select, and the chart-type gallery are no longer shifted right
relative to their step icons.
3. `ChartCreation.test.tsx` includes a regression test asserting
`.ant-steps-item-wrapper` has `column-gap: 0` and `.ant-steps-item-icon` keeps
`margin-right: 8px`.
### ADDITIONAL INFORMATION
- [x] Has associated tests
- [ ] Requires DB Migration
- [ ] Confirm DB Migration upgrade and downgrade tested
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
