mikebridge commented on PR #42534: URL: https://github.com/apache/superset/pull/42534#issuecomment-5484152603
@rusackas this is ready for another look — both items from your change request have been fixed since 08-06, and the branch was freshly rebased today: - **Gate ordering**: `samples()` now runs the guest checks (404 for non-dataset types before the DatasetDAO lookup, drill-access 403) and the per-object `raise_for_access` (via `_load_dataset_for_samples`) **before** the `supports_samples` capability gate, with tests pinning 404-beats-400 for a semantic view and the 403 arm. - **`<pre>` → `Alert`**: multi-line errors keep their line breaks via a shared `PreformattedErrorDescription` (`white-space: pre-wrap`, theme code font, `overflow-wrap: anywhere`) used by `SamplesPane`, `useResultsPane`, and `DrillDetailPane`, with the regression test asserting the preserved newlines. Current head `07eadf5fcc` is a clean rebase onto master with CI fully green (0 failures), and today's bot round found nothing actionable. The two remaining CodeAnt threads are answered and resolved above. (I can't re-request review via the API without triage rights — hence the ping.) _Comment generated by Claude (AI) on behalf of @mikebridge._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
