fitzee commented on PR #43633: URL: https://github.com/apache/superset/pull/43633#issuecomment-5491673490
CI diagnosis for [run 33485387630](https://github.com/apache/superset/actions/runs/33485387630): - **Shard 3:** confirmed as the unrelated SqlEditor/Ant Tabs nwsapi selector flake (`SyntaxError: ...ant-tabs-nav-more...:focus-visible is not a valid selector`). No change made. - **Shard 6:** genuine production ordering bug. The full log showed the final datasource contained `default_endpoint` but had lost both certification fields. Certification used functional updates, but the adjacent Basic `Fieldset` still emitted a complete datasource snapshot through `onDatasourceChange`; when that debounced callback landed last/in the same React batch, it replaced the pending certification updates. Fixed in `cdf5e65246` by adding a field-level `Fieldset.onFieldChange` path and using functional, single-property updates for the Basic, Advanced, and Certification sections on the Settings tab. Full-record behavior remains available for collection editors that need it. The regression now deterministically batches both certification callbacks and a trailing Basic callback with fake timers—the ordering that reproduces the CI failure before the fix. Validation: - The deterministic regression failed before the production change and passes after it. - `DatasourceEditorDatasetCertification.test.tsx`: 5 consecutive runs, 2/2 tests passed each run. - Focused coverage run: 4 suites passed (dataset helper, dataset editor, metric certification, modal). - Staged `pre-commit run`: passed, including frontend format/lint/custom rules/stylelint/type checking. We cannot rerun the old upstream jobs; this push has triggered a fresh CI run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
