codeant-ai-for-open-source[bot] commented on code in PR #43763:
URL: https://github.com/apache/superset/pull/43763#discussion_r3904829482
##########
superset/commands/importers/v1/utils.py:
##########
@@ -594,3 +595,17 @@ def clear_soft_deleted_for_import(existing: Any) -> None:
"""
db.session.delete(existing)
db.session.flush()
+
+
+def apply_extra_import_fields(
+ model: Any, asset_type: str, extra: dict[str, Any] | None
+) -> None:
+ """Hand the exported ``extra`` mapping to the deployment's import handler.
+
+ No-op unless ``EXTRA_ASSET_IMPORT_HANDLER`` is configured, so imports are
+ unchanged by default. Called once the asset exists and has an id.
+ """
+ if not extra:
+ return
+ if handler := current_app.config.get("EXTRA_ASSET_IMPORT_HANDLER"):
+ handler(model, asset_type, extra)
Review Comment:
**Suggestion:** The handler runs before the import transaction finishes, so
external metadata changes remain when later dashboard or relationship updates
fail and the database rolls back. [incomplete implementation]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a68dea848a8448f9aa5659627db44e33&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a68dea848a8448f9aa5659627db44e33&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/importers/v1/utils.py
**Line:** 611:611
**Comment:**
*Incomplete Implementation: The handler runs before the import
transaction finishes, so external metadata changes remain when later dashboard
or relationship updates fail and the database rolls back.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43763&comment_hash=9b2175c3b5f096ab9478d9efc5c6edbf3778b20228444764b9e3f0456b49edc1&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43763&comment_hash=9b2175c3b5f096ab9478d9efc5c6edbf3778b20228444764b9e3f0456b49edc1&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
