codeant-ai-for-open-source[bot] commented on code in PR #43783:
URL: https://github.com/apache/superset/pull/43783#discussion_r3910217717
##########
superset/semantic_layers/api.py:
##########
@@ -558,6 +563,13 @@ class SemanticLayerRestApi(BaseSupersetApi):
"types": "read",
"configuration_schema": "read",
"runtime_schema": "read",
+ # ``read`` (not the default ``can_views`` / ``can_connections``) so
+ # these stay broadly accessible: ``SemanticLayer`` is in
+ # ``READ_ONLY_MODEL_VIEWS``, where every permission outside
+ # ``READ_ONLY_PERMISSION`` is admin-only. Both are read operations
+ # (view discovery and the combined connection picker).
+ "views": "read",
+ "connections": "read",
Review Comment:
**Suggestion:** The Gamma-readable `connections` endpoint queries every
database without datasource-access filtering, exposing database names and
connection metadata to unauthorized users. [security]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=444b15a6d63948aba5ca8b8e4b317beb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=444b15a6d63948aba5ca8b8e4b317beb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/semantic_layers/api.py
**Line:** 572:572
**Comment:**
*Security: The Gamma-readable `connections` endpoint queries every
database without datasource-access filtering, exposing database names and
connection metadata to unauthorized users.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43783&comment_hash=1af027ec52e58d3fc7cc93cf510fe7fc7b1d9c22d9c8afef15fee36be98b0aa8&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43783&comment_hash=1af027ec52e58d3fc7cc93cf510fe7fc7b1d9c22d9c8afef15fee36be98b0aa8&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
