bito-code-review[bot] commented on PR #43788:
URL: https://github.com/apache/superset/pull/43788#issuecomment-5505008270
<!-- Bito Reply -->
The issue is that `DashboardColorsConfigUpdateSchema` is likely missing
explicit type definitions for the `shared_label_colors` field, causing the
OpenAPI generator to default to an empty object schema. To resolve this, you
should explicitly define the field in your Marshmallow schema using
`fields.List(fields.String())`.
Example fix:
```python
from marshmallow import fields, Schema
class DashboardColorsConfigUpdateSchema(Schema):
shared_label_colors = fields.List(fields.String(), required=False)
```
Regarding other comments on this PR, I do not have access to the full list
of comments as the provided `pr_comments.csv` file is empty. If you would like
me to review other issues, please ensure the comment file is populated.
**superset/dashboards/api.py**
```
from marshmallow import fields, Schema
class DashboardColorsConfigUpdateSchema(Schema):
shared_label_colors = fields.List(fields.String(), required=False)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
