EnxDev commented on code in PR #43017: URL: https://github.com/apache/superset/pull/43017#discussion_r3914058201
########## superset/commands/dashboard/export.py: ########## @@ -48,6 +48,13 @@ DEFAULT_CHART_WIDTH = 4 +def _coerce_dataset_id(raw_dataset_id: Any) -> Optional[int]: + try: + return int(raw_dataset_id) Review Comment: Thanks—this stricter check and the regression coverage address my concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
