john-bodley commented on a change in pull request #8418: Flask App factory PR #1 URL: https://github.com/apache/incubator-superset/pull/8418#discussion_r347187179
########## File path: superset/bin/superset ########## @@ -15,17 +15,7 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -import click -from flask.cli import FlaskGroup - -from superset.cli import create_app - - [email protected](cls=FlaskGroup, create_app=create_app) -def cli(): - """This is a management script for the Superset application.""" - pass - +from superset.cli import superset if __name__ == '__main__': - cli() + superset() Review comment: I think we could annex this file and have `setup.py` reference `superset.cli:superset`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
