fitzee commented on PR #43784: URL: https://github.com/apache/superset/pull/43784#issuecomment-5516832648
@rebenitez1802 Thanks for the thorough review — I pushed `3a7bee00c9` to address the findings. Changes made: - Made uniform-tile detection clip-aware and excluded terminal empty/error holders. - Uniform pixels still trigger repaint/retry, but after three uniform results the tile is retained with a structured warning. Pixel colour alone no longer hard-fails an otherwise valid map, empty state, or sparse final tile. - Moved capture-timeout calculation inside the retry loop so every attempt uses the current remaining execution budget. - Persistent Playwright capture timeouts now propagate a specific `ScreenshotCaptureTimeoutError` instead of degrading to `None`. - Guarded the clip-holder diagnostic evaluation so an execution-context race cannot discard an otherwise valid capture. - Treated AG Grid's visible no-rows overlay as a terminal empty state, including the standalone-chart predicate. - Limited sampled colour enumeration to 256 and removed the unreachable post-loop blank-error branch in favor of the loop invariant. - Strengthened the retry test to verify the suspicious tile is discarded, asserted the retry diagnostic, removed the brittle full-context assertion, and added tests for timeout recovery, shrinking retry budgets, persistent timeout failure, diagnostic-evaluation failure, persistent legitimate uniform content, and zero-row AG Grid. - Updated `UPDATING.md`. The focused suite passes: **66 passed**. Extended scheduled testing also caught three real tile-1 Chromium stalls. Each reached the new 120-second bound, retried, and delivered a populated PDF successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
