codeant-ai-for-open-source[bot] commented on code in PR #43487:
URL: https://github.com/apache/superset/pull/43487#discussion_r3920595411
##########
superset-frontend/playwright/tests/experimental/dashboard-v2/filters.spec.ts:
##########
@@ -213,7 +213,12 @@ test("a filter's default scope excludes a chart on a
different dataset", async (
).toBe(false);
});
-test('an explicit scope.targets list narrows which same-dataset chart a filter
affects', async ({
+// Skipped: SchemaControlPanel's loadSeries effect fires an extra,
+// unscoped fetchQueryData call whenever the Inspector applies a
+// dataBinding, independent of ChartWidget's own scope-aware fetch โ so
+// the out-of-scope chart here refetches once more than this test expects.
+// Not a scope.targets bug; see SchemaControlPanel.tsx's `loadSeries` effect.
+test.skip('an explicit scope.targets list narrows which same-dataset chart a
filter affects', async ({
Review Comment:
**Suggestion:** This permanently disables the only browser test verifying
that `scope.targets` prevents a same-dataset, non-targeted chart from
refetching, allowing future regressions to pass unnoticed. [incomplete
implementation]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=933402beb5c342c79ce81c3ccd491fc4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=933402beb5c342c79ce81c3ccd491fc4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/playwright/tests/experimental/dashboard-v2/filters.spec.ts
**Line:** 221:221
**Comment:**
*Incomplete Implementation: This permanently disables the only browser
test verifying that `scope.targets` prevents a same-dataset, non-targeted chart
from refetching, allowing future regressions to pass unnoticed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43487&comment_hash=638f5b3d4c0ff3da147aadabcfaf15490690d9336d6e59832de1e4afbef51ab2&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43487&comment_hash=638f5b3d4c0ff3da147aadabcfaf15490690d9336d6e59832de1e4afbef51ab2&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
