nytai commented on PR #43809: URL: https://github.com/apache/superset/pull/43809#issuecomment-5519682523
Addressed the Bito comment about `Show.db` changing from an `Identifier` to a `Table`: it was right, and it surfaced a real bug in `_find_show_statement_tables` — `find_all(exp.Table)` picked up the schema-only `Table` (no table part) as a phantom empty-name table reference, regressing the documented invariant that a schema-only `SHOW TABLES` target should extract zero tables and be flagged unparseable for authorization. It also meant a target-bearing statement like `SHOW COLUMNS FROM tbl FROM catalog.schema` would read `db.name` (empty for a table-less `Table`) instead of `.db`/`.catalog`, silently dropping the schema. Fixed in the latest commit, with regression tests covering both cases. (The CodeAnt comment claiming `sqlglot.parsers.starrocks` doesn't exist in sqlglot 30.x doesn't hold up — replied inline with verification against the pinned `v30.17.0` tag.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
