villebro opened a new pull request, #43810: URL: https://github.com/apache/superset/pull/43810
### SUMMARY Hydrates legacy ECharts time-series form data that still stores the temporal column in `granularity` by copying it into `x_axis` when the `x_axis` key is absent. This keeps old charts rendering correctly and also populates the x-axis control when those charts are opened in Explore. The guard preserves charts that already have an `x_axis` key, including explicit empty values being edited. I checked existing migrations before taking this path. The legacy-viz migration helper maps `granularity_sqla` to `x_axis` while converting old viz types, but I did not find a persisted migration that rewrites existing ECharts form data from `granularity` to `x_axis`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not included; this is a form-data compatibility fix. ### TESTING INSTRUCTIONS - `cd superset-frontend && npm run test -- src/explore/store.test.tsx` - `cd superset-frontend && npm run test -- src/explore/actions/hydrateExplore.test.ts` - `pre-commit run` was run on the staged files. It passed formatting/lint hooks but failed the frontend type-check hook on unrelated existing errors in `src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx` and `src/types/bootstrapTypes.ts`, both importing symbols from `@superset-ui/core` that are not exported in this local checkout. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
