sadpandajoe commented on code in PR #43712:
URL: https://github.com/apache/superset/pull/43712#discussion_r3924862905
##########
docs/developer_docs/components/ui/select.mdx:
##########
@@ -283,7 +282,6 @@ function OneLineDemo() {
| Prop | Type | Default | Description |
|------|------|---------|-------------|
| `mode` | `string` | `"single"` | Whether to allow selection of a single
option or multiple. |
-| `placeholder` | `string` | `"Select ..."` | Placeholder text when no option
is selected. |
| `showSearch` | `boolean` | `true` | Whether to show a search input for
filtering. |
Review Comment:
The component and its source-of-truth story still accept and document
`placeholder`, but this change removes it from the generated Props table. That
leaves users without the supported prop/default in the published API docs;
should the table retain it (or remove it from the story/component)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
