craig-rueda commented on a change in pull request #8418: Flask App factory PR #1 URL: https://github.com/apache/incubator-superset/pull/8418#discussion_r347557891
########## File path: tests/access_tests.py ########## @@ -14,12 +14,14 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. +# isort:skip_file """Unit tests for Superset""" import json import unittest from unittest import mock -from superset import app, db, security_manager +from tests.test_app import app # isort:skip Review comment: In this case, we need tests.test_app to load before importing downstream modules, as they end up requiring the app to have been initialized at import time. Next PR will start to clean up transitive package loads... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
