bito-code-review[bot] commented on PR #43811:
URL: https://github.com/apache/superset/pull/43811#issuecomment-5527582767
<!-- Bito Reply -->
The flagged issue is correct. Adding a fixed 8-pixel buffer to the input
width can indeed cause layout overflow or displacement in constrained
containers. To resolve this, you can use a more flexible approach, such as
applying `min-width` or ensuring the container has `overflow: hidden` and
`text-overflow: ellipsis` to handle cases where the title exceeds the available
space.
Regarding other comments on this PR: I have checked the review comments, and
there are no other actionable suggestions currently listed in the review
thread. Would you like me to proceed with implementing the suggested fix for
this layout issue?
**superset-frontend/packages/superset-ui-core/src/components/DynamicEditableTitle/index.tsx**
```
width: ${inputWidth}px;
min-width: ${inputWidth}px;
max-width: 100%;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
