mikebridge commented on code in PR #43777:
URL: https://github.com/apache/superset/pull/43777#discussion_r3926187333
##########
superset/semantic_layers/models.py:
##########
@@ -322,6 +332,99 @@ def get_query_result(self, query_object: QueryObject) ->
QueryResult:
def get_query_str(self, query_obj: QueryObjectDict) -> str:
return "Not implemented for semantic layers"
+ @property
+ def normalize_columns(self) -> bool:
+ """Dimension names are provider-verbatim; nothing to (de)normalize.
+
+ Exists for the datasource values endpoint, which reads it before
+ requesting filter-value suggestions.
+ """
+ return False
+
+ def values_for_column(
+ self,
+ column_name: str,
+ limit: int = 10000,
+ denormalize_column: bool = False, # pylint: disable=unused-argument
+ array_elements: bool = False, # pylint: disable=unused-argument
Review Comment:
False positive, verified against the type mapping: `get_column_type`
(superset/semantic_layers/models.py) has no `MULTI_VALUE` branch — Arrow
list/struct types fall through to `STRING` — so no semantic-view column ever
reports `type_generic = MULTI_VALUE`, the Explore popover never offers the
*Contains any/all* operators for them, and the UI cannot send
`array_elements=true` for a semantic-view column. The parameter is accepted for
endpoint-signature compatibility and documented as a dataset concept with no
semantic-view counterpart. If list-typed dimensions ever get first-class
treatment (a `MULTI_VALUE` mapping), element explosion would need provider
support and its own design — out of scope here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
