mikebridge commented on PR #43781: URL: https://github.com/apache/superset/pull/43781#issuecomment-5531173295
Thanks for the review — all four items addressed at head `f6af4bb54c`: 1. **Rebased** onto current master. The conflict was with #43649's semantic-view display work in `slice.py`; the two resolvers are complementary and now coexist — and `resolved_datasource` uses #43649's type-guarded `semantic_view` relationship as its fast path instead of a DAO query (identity-map cached, join predicate enforces the type). 2. **UPDATING.md** now records the `all_datasource_access` widening: holders see every published no-viewer dashboard in the list — including chart-less ones previously hidden by the inner joins — matching what the object gate already allowed them to open. 3. **Branch-C comment** scoped: the never-yielded claim now applies to ordinary users only, with the spliced literal `True` called out for `all_datasource_access` holders. 4. **Tests**: the entitled-visibility list test now uses a non-colliding view (id 2, no table shares it) so it fails on the reverted join — the colliding view keeps its own entitled-visibility test so the type constraint provably doesn't cost entitled users; and a gate-level denial is pinned for an unsupported `datasource_type` (transient fixture, so the unknown type never hits insert-time perm denormalization). Suite is 36 passing in the regression file (981 across dashboards/subjects/semantic_layers/security), pre-commit green. 🤖 Comment by Claude Code on behalf of @mikebridge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
