justinpark opened a new pull request, #43833:
URL: https://github.com/apache/superset/pull/43833

   ### SUMMARY
   
   A prior playwright fix commit (#43487) updated the selector on the 
assumption that the tab had been renamed to "Widgets", but a later @EnxDev's 
commit 
([#43588](https://github.com/apache/superset/pull/43588/changes#diff-297f1f61a41f190d99bdacc63c73180be01c6a560f5d0f28d9ed2c98f29384b7R322))
 had actually renamed it the other way, back to "Building Blocks".
   
   This updates the selector (and its accompanying comment) in
   `DashboardV2Page.ts` to look for "Building Blocks", matching the label
   that's actually rendered.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A
   
   ### TESTING INSTRUCTIONS
   Run the experimental Dashboard v2 Playwright
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to