mikebridge commented on PR #43830:
URL: https://github.com/apache/superset/pull/43830#issuecomment-5533147884
Thanks for the careful review @rebenitez1802 — all addressed in `72152ba81a`:
- 🟡 **Removed the internal tracker reference.** Genericized the test comment
to describe the regression itself (`// Regression: opening a version as new
stranded a blank about:blank tab because window.open(..., 'noopener') returns
null…`); no non-Apache IDs remain in the diff, and the squashed commit body is
already clean of them.
- 🟢 **`openBlankTab` now asserts the exact call.** Replaced the
`noopener`-token check with `expect(openSpy).toHaveBeenCalledWith('',
'_blank')`, so re-introducing `noreferrer` alone (which also nulls the handle)
now fails the test.
- 🟢 **URL-validation-ordering test pins `close` too.** Added
`expect(tab.close).not.toHaveBeenCalled()`, so moving `tab.close()` ahead of
`assertSafeNavigationUrl` would be caught.
- 🟢 **Documented the defensive external branch.** Added a docstring caveat
on `navigateOpenedTab` noting the `!isSameOriginRoute` path is unreachable for
current callers and that a post-await external target would be popup-blocked.
82/82 on the file, changed-file pre-commit clean (oxfmt/oxlint/tsc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
