mikebridge opened a new pull request, #43836: URL: https://github.com/apache/superset/pull/43836
### SUMMARY QA (SC-118366) found that on dashboards the open version-history panel — a 320px inline drawer in the third column of the builder grid — has its right edge pinned at ~1446px regardless of viewport width: the grid's content column cannot shrink below its min-content width, so below ~1446px the panel is pushed past the page width, clipping its own version rows, kebab menus, and close ✕ behind horizontal scroll (measured: +6px overflow at 1440, +166px at 1280). Fix mirrors the responsive pattern the Explore version-history host already uses (`ExploreVersionHistory`'s `PanelHost`): below the `screenXXL` antd breakpoint, `VersionHistoryColumn` becomes a **fixed overlay pinned to the viewport's right edge** (removed from grid flow, so nothing overflows at any narrower width), above the dashboard header (`z-index 101`), with the theme shadow; an `:empty` guard keeps a closed (portal-only) column from painting a stray shadow sliver. At wide viewports the side-by-side layout is unchanged. The breakpoint is the token-based `screenXXL` (1600) rather than the measured 1446: the inline-fit threshold moves with the filter-bar state and grid min-content, so the token gives margin instead of a magic number; between 1446-1599 the panel overlays where it previously fit inline — a deliberate trade for never overflowing. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before (QA evidence on the ticket): at 1280px the panel's right edge exceeds the viewport by 166px, controls off-screen. After: at any width below 1600 the panel overlays anchored to the right edge; close ✕ and version rows stay reachable. ### TESTING INSTRUCTIONS 1. Open a dashboard → ⋮ menu → "View version history" at viewport widths 1280 / 1366 / 1440: the panel hugs the viewport's right edge, no horizontal page scroll, close ✕ and kebab menus reachable. 2. At ≥1600px: unchanged side-by-side layout (panel in the grid column). 3. With the panel closed at <1600px: no shadow artifact at the right edge. 4. `npm run test -- src/dashboard/components/DashboardBuilder` — builder suites pass. ### ADDITIONAL INFORMATION - [x] Has associated issue: SC-119737 (Preset Shortcut, QA of SC-118366) - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01JRLEJS4mUqKBoPjSjviKUW -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
