mikebridge commented on PR #43490: URL: https://github.com/apache/superset/pull/43490#issuecomment-5533818994
Rebased onto latest `master` (the branch was 225 commits behind) and force-pushed to `5acd469b2a`. What changed in the rebase: - **UPDATING.md conflict resolved keeping both entries** — master's `### Archived dataset purge requires impact confirmation` (from #43724) and this PR's `- The purge audit log can now be pruned automatically…` bullet now coexist under `## Next`. - **Migration chain re-pointed to keep a single alembic head.** Master advanced `39097d124752` with `8f31c5d726ab` (`index_dataset_dependency_lookups`), which would have left this PR's `a6c21e5b4d93` as a second head off `39097d124752`. `a6c21e5b4d93` is now chained onto `8f31c5d726ab`, so `c7f53d184ea2` is the sole head. The `enforce-single-migration-head` pre-push gate passes. - No code changes beyond the conflict resolution and the down-revision re-point; changed-file pre-commit is clean (mypy / ruff / pylint all green). @rusackas — heads-up that the existing approval predates **both** the earlier delta-review fix (the differing-reason timestamp-tie that could delete a reason-transition run-head, fixed with inclusive tie bounds + a control-run test) **and** this rebase, so GitHub is still showing the old green badge. Could you take a fresh look before merge rather than merging on the stale approval? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
