rusackas commented on code in PR #41285:
URL: https://github.com/apache/superset/pull/41285#discussion_r3930321736
##########
superset-frontend/src/extensions/ExtensionsStartup.tsx:
##########
@@ -67,9 +70,28 @@ const ExtensionsStartup: React.FC<{ children?:
React.ReactNode }> = ({
views,
};
+ // Load extensions without blocking the initial render (see #40915);
+ // surface any load failure as a warning toast instead of failing silently.
if (isFeatureEnabled(FeatureFlag.EnableExtensions)) {
- ExtensionsLoader.getInstance().initializeExtensions();
+ ExtensionsLoader.getInstance()
+ .initializeExtensions()
+ .then(() =>
Review Comment:
Good catch. `initializeExtensions()` now resolves with the names of anything
that failed to load, and the startup path raises a warning toast naming them
instead of logging success.
##########
superset-frontend/src/core/sqlLab/index.ts:
##########
@@ -161,19 +161,29 @@ const makeTab = (
catalog: string | null = null,
schema: string | null = null,
closed: boolean = false,
+ backendId?: string,
): Tab => {
const panels: Panel[] = []; // TODO: Populate panels
const editorGetter = closed
? () => Promise.reject(new Error(`Tab ${id} has been closed`))
: () => getEditorAsync(id);
- return new Tab(id, name, dbId, catalog, schema, editorGetter, panels);
+ return new Tab(
+ id,
+ name,
+ dbId,
+ catalog,
+ schema,
+ editorGetter,
+ panels,
+ backendId,
+ );
};
const getTab = (id: string): Tab | undefined => {
const queryEditor = findQueryEditor(id);
if (queryEditor?.dbId !== undefined) {
- const { name, dbId, catalog, schema } = queryEditor;
- return makeTab(id, name, dbId, catalog, schema);
+ const { name, dbId, catalog, schema, tabViewId } = queryEditor;
Review Comment:
Yep, hydrated tabs carry the backend id as `queryEditor.id`, so `backendId`
now falls back to that whenever the editor is not flagged `inLocalStorage`.
Added a test for the reload case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
