sadpandajoe opened a new pull request, #43849: URL: https://github.com/apache/superset/pull/43849
## Summary - The SQL Lab Run control's split-button dropdown (shown when CTAS/CVAS is allowed) passed its menu content through antd's `overlay` prop. Antd v6 dropped that deprecated prop entirely, so the menu never reached antd's internal `Dropdown`, and clicking the caret threw `React.Children.only expected to receive a single React element child.` - Separately, the caret icon used `theme.colorIcon` (a neutral "weak action" token) instead of a color meant to contrast against the primary button background, rendering it in the wrong dark/grey shade. - Fixes both by passing the menu via the already-supported `popupRender` prop and using `theme.colorTextLightSolid` for the caret icon color. This addresses a customer-reported issue. ## Before / After **Before** — dark/grey caret on the primary button, and clicking it crashes with `React.Children.only`:  **After** — caret color matches the button's other icon, and the dropdown menu opens correctly:  ## Test plan - [x] Added a failing-first RTL test reproducing the `React.Children.only` crash on caret click, confirmed it failed for the predicted reason, then fixed it - [x] Added a failing-first RTL test asserting the caret icon color, confirmed it failed for the predicted reason, then fixed it - [x] Added a general regression test to `DropdownButton.test.tsx` covering `popupRender` + click trigger - [x] All 16 relevant Jest tests pass - [x] Pre-commit (oxfmt/oxlint/stylelint/type-check) passes on changed files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
