Kunal8954 opened a new pull request, #43859:
URL: https://github.com/apache/superset/pull/43859

   DefaultValue.tsx rebuilds its filterState prop as a brand-new object literal 
on every render. That object flows down through SuperChart into the native 
filter plugin and ends up as the value prop of the underlying Select. Giving it 
a new identity on every render — including renders triggered by unrelated 
causes, since the config modal calls forceUpdate() after every dataMask change 
— is exactly the pattern flagged as the root cause in #43347's investigation.
   
   This memoizes the object on its underlying source plus the two derived 
validation fields, so it keeps the same reference across renders that don't 
actually change anything.
   
   Added DefaultValue.test.tsx with a regression test that fails without this 
fix (proven locally) and passes with it.
   
   Fixes #43717


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to