mikebridge commented on PR #43776:
URL: https://github.com/apache/superset/pull/43776#issuecomment-5545756393
@aminghadersohi — reconciled against the code, and the answer is "both,
precisely": you're right that #43350 suppresses the hydration-default
normalization on a plain Explore save, so the entry as written was overbroad.
But the specific example the doc used — `granularity_sqla`/`time_range` →
`adhoc_filters` — is #43350's **deliberate residual**: the save path itself
stamps it (along with `dashboards`/`extra_form_data`), so that one genuinely
records on the first modernizing save even in the plain case ("arguably genuine
history", per that PR's own notes). The broader automatic-rewrite set surfaces
exactly where you said: `hydrateExplore`'s tracking gate deliberately skips
evidence collection when the page is opened with cached `form_data_key` data,
with a `dashboardId`, or with a `viz_type` URL param — fail-open, so those
entry points can record the wider set on a first save.
So: no suppression gap to file — the plain-save residual is intended. The
docs now say precisely that (plain save → temporal-migration residual only;
dashboard/shared-link/viz-type entry points → possibly the broader set), and
both files now name the third origin the same way ("or the API").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
